835969 - about:plugins no longer shows the full path when plugin.expose_full_path true is set

Status: RESOLVED DUPLICATE of bug 661961

(Core Graveyard :: Plug-ins, defect, P5)

Description

[Kevin Brosnan [Ex-Mozilla]]

STR
* open about:config and click through the warning
* use the search bar to find plugin.expose_full_path and double click on it to set it to true
* open about:plugins
* only plugin file name is shown, the full path to the plugin should be displayed


Very likely bug 831533 regressed this.

Comment 1

[Alice0775 White]

Regression window:
Good:
http://hg.mozilla.org/integration/mozilla-inbound/rev/9d5aa1109267
Mozilla/5.0 (Windows NT 6.1; WOW64; rv:21.0) Gecko/20130110 Firefox/21.0 ID:20130110132009
Bad:
http://hg.mozilla.org/integration/mozilla-inbound/rev/42b22f0ab58c
Mozilla/5.0 (Windows NT 6.1; WOW64; rv:21.0) Gecko/20130110 Firefox/21.0 ID:20130110132310
Pushlog:
http://hg.mozilla.org/integration/mozilla-inbound/pushloghtml?fromchange=9d5aa1109267&tochange=42b22f0ab58c

Regressed by:
42b22f0ab58c	Chris Peterson — Bug 757726 - Part 1: Update about:plugins to use document.createElement() and AddonManager. r=joshmoz

Comment 2

[Dave Garrett]

This option exposes the full path of the plugin to web content, but gets used for troubleshooting here. A better route would be to just add the paths to about:plugins and get rid of the pref.

Comment 3

[Lukas Blakk [:lsblakk] use ?needinfo]

Tracking this regression, assigning to Chris to investigate the options here.

Comment 4

[Benjamin Smedberg]

I almost closed this WONTFIX, and I strongly disagree with tracking this. It's just not important.

Comment 5

[Chris Peterson [:cpeterson]]

(In reply to Benjamin Smedberg  [:bsmedberg] from comment #4)
> I almost closed this WONTFIX, and I strongly disagree with tracking this.
> It's just not important.

I think showing the plugin path may be useful because someone may have multiple plugins installed. On OSX, for example, a user may have plugins installed in ~/Library/Internet\ Plug-Ins and /Library/Internet\ Plug-Ins.

If this bug is closed as WONTFIX, then I suggest we also remove the plugin.expose_full_path pref and its supporting code. AFAIK, if we don't expose full plugin paths in about:plugins, then we would only be exposing the paths to web content in navigator.plugins, which may be a security risk.

Comment 6

[Benjamin Smedberg]

Given that about:plugins is no longer using the DOM APIs, you can just make it always display the full path, and remove the pref. That's why I didn't close this WONTFIX ;-)

Comment 7

[Lukas Blakk [:lsblakk] use ?needinfo]

Thanks for comment 6, given that information we will not track.

Comment 8

[Dave Garrett]

I apparently filed bug 661961 about this pref a while back. (I vaguely remember someone accidentally forgetting about the pref and leaking paths onto the web.) If you want a separate bug for the about:plugins and pref removal bits it's there, or you can dupe one to the other.

Comment 9

[Chris Peterson [:cpeterson]]

I was going to fix this bug today, but then I saw that someone already posted a WIP patch on bug 661961. :D